Use AuthedRelationship to power byTracking #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: f550dba We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jesstelford
force-pushed
the
bytracking-authedrelationship
branch
3 times, most recently
from
bc865e8
to
2dfa0b7
Compare
MadeByMike
approved these changes
Apr 23, 2020
MadeByMike
reviewed
Apr 23, 2020
jesstelford
force-pushed
the
bytracking-authedrelationship
branch
from
2dfa0b7
to
f550dba
Compare
Merged
Wkasel
pushed a commit
to gosignal/keystone
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The failing test is due to a different bug fixed in #2813
Noticed some of this logic was duplicated, so figured we could just re-use what exists to simplify the byTracking code.
Things
AuthedRelationshiphandles for us:{ create: false, read: true, update: false }createdByvalue on creationThings
AuthedRelationshipfixes for us:access: { ... }syntax. ie; to toggleread: false, all it takes is aaccess: { read: false }instead of currently which requires re-specifying all three options, potentially leading to subtle bugs which make the access too permissive.isRequiredflag on create