-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Apply hash link offset to H4s #2925
Conversation
💥 No ChangesetLatest commit: d272fc1 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
@@ -4,7 +4,15 @@ import { jsx } from '@emotion/core'; | |||
import { colors, gridSize } from '@arch-ui/theme'; | |||
import { LinkIcon } from '@arch-ui/icons'; | |||
|
|||
import { mq } from '../../utils/media'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not using any responsive stuff here so this can be removed
const hashLinkOffset = { | ||
'::before': { | ||
content: '" "', | ||
height: 'calc(32px + 60px)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is using calc
, I must've had some dynamic number in there at one point. Happy to leave as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this! Thanks for fixing ❤️
Fixes an issue where h4 headings will be anchored to the very top of the page and be hidden by the header
https://www.keystonejs.com/keystonejs/fields/src/types/calendar-day/#format