Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Apply hash link offset to H4s #2925

Merged
merged 3 commits into from
May 8, 2020
Merged

website: Apply hash link offset to H4s #2925

merged 3 commits into from
May 8, 2020

Conversation

jordanoverbye
Copy link
Contributor

Fixes an issue where h4 headings will be anchored to the very top of the page and be hidden by the header

https://www.keystonejs.com/keystonejs/fields/src/types/calendar-day/#format

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2020

💥 No Changeset

Latest commit: d272fc1

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -4,7 +4,15 @@ import { jsx } from '@emotion/core';
import { colors, gridSize } from '@arch-ui/theme';
import { LinkIcon } from '@arch-ui/icons';

import { mq } from '../../utils/media';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using any responsive stuff here so this can be removed

const hashLinkOffset = {
'::before': {
content: '" "',
height: 'calc(32px + 60px)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is using calc, I must've had some dynamic number in there at one point. Happy to leave as is for now.

Copy link
Member

@jossmac jossmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this! Thanks for fixing ❤️

@timleslie timleslie merged commit cfe4527 into master May 8, 2020
@timleslie timleslie deleted the website-h4-links branch May 8, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants