Add support for arguments on Virtual fields #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 281a688 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
timleslie
force-pushed
the
virtual-field-param
branch
from
007a2fd
to
880c07e
Compare
jesstelford
approved these changes
May 12, 2020
|
How're we testing the Virtual field? |
|
You're right, it's currently pretty light on for tests, I'll add some as part of this PR 👍 |
timleslie
force-pushed
the
virtual-field-param
branch
from
880c07e
to
6419db9
Compare
timleslie
force-pushed
the
virtual-field-param
branch
from
6419db9
to
281a688
Compare
This was referenced May 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.