Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro-to-graphql.md #3626

Merged
merged 7 commits into from Sep 11, 2020
Merged

Update intro-to-graphql.md #3626

merged 7 commits into from Sep 11, 2020

Conversation

rodshtein
Copy link
Contributor

Added explanation about search operators

Added explanation about search operators
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2020

💥 No Changeset

Latest commit: 555d137

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodshtein
Copy link
Contributor Author

Looks like i don't need a changeset for docs?

@@ -308,7 +308,7 @@ query {

### `search`

Will search the list to limit results.
Will search the list to limit results. It can search only by [labelField](/docs/api/create-list.md#labelfield).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite true. At the moment the search is applied to a Text field called name. This is not currently configurable, although that is a feature which is on our backlog.

Copy link
Contributor Author

@rodshtein rodshtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timleslie I changed it to:

"For now, it can search only by name field. The name field must be a Text type."

👇👇

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @zamkevich, this will hopefully clear things up a bit for readers of this documentation.

@timleslie timleslie merged commit f2f0a8f into keystonejs:master Sep 11, 2020
@rodshtein rodshtein deleted the patch-1 branch September 13, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants