Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label and assorted a11y fixes to timestamp field #5893

Merged
merged 4 commits into from
Jun 11, 2021

Conversation

gwyneplaine
Copy link
Contributor

  • timestamp field now wrapped in fieldset and given a legend element, rathern than a div and label respectively
  • adjusted date picker clear value button to have SR friendly clear icon
  • added visually hidden label for time input for better SR experience.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2021

🦋 Changeset detected

Latest commit: f36652e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-ui/fields Patch
@keystone-next/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/7i3wn4SMVfMjJ8TFmK8ZcDdmvPBJ
✅ Preview: https://keystone-next-docs-git-a11y-time-stamp-field-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 11, 2021 03:32 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview June 11, 2021 03:58 Inactive
@gwyneplaine gwyneplaine requested a review from a team June 11, 2021 04:00
@gwyneplaine gwyneplaine enabled auto-merge (squash) June 11, 2021 04:02
@gwyneplaine gwyneplaine merged commit df7d7b6 into master Jun 11, 2021
@gwyneplaine gwyneplaine deleted the a11y/time-stamp-field branch June 11, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants