Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev startup performance experimenting #6047

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 25 additions & 3 deletions packages/keystone/src/artifacts.ts
Expand Up @@ -4,6 +4,7 @@ import * as fs from 'fs-extra';
import type { KeystoneConfig } from '@keystone-next/types';
import { getGenerator, formatSchema } from '@prisma/sdk';
import { format } from 'prettier';
import { predefinedGeneratorResolvers } from '@prisma/sdk/dist/predefinedGeneratorResolvers';
import { confirmPrompt, shouldPrompt } from './lib/prompts';
import { printGeneratedTypes } from './lib/schema-type-printer';
import { ExitError } from './scripts/utils';
Expand Down Expand Up @@ -204,10 +205,31 @@ export async function generateNodeModulesArtifacts(
]);
}

const prismaClientDir = path.dirname(require.resolve('@prisma/client/package.json'));

async function generatePrismaClient(cwd: string) {
const generator = await getGenerator({ schemaPath: getSchemaPaths(cwd).prisma });
await generator.generate();
generator.stop();
const prevPredefinedGeneratorResolver = predefinedGeneratorResolvers['prisma-client-js'];
try {
// this is ofc v bad and relying on implementation details of prisma
// but we use fixed versions of prisma so we will know exactly when this breaks
// this hack exists because predefinedGeneratorResolvers['prisma-client-js']
// does some really slow things that aren't really necessary for us
// the big thing seems to be it traverses like every directory inside of your cwd trying the @prisma/client package
// (not sure if it's exactly that but something like that)
predefinedGeneratorResolvers['prisma-client-js'] = async () => {
return {
outputPath: prismaClientDir,
generatorPath: path.resolve(prismaClientDir, 'generator-build/index.js'),
isNode: true,
};
};

const generator = await getGenerator({ schemaPath: getSchemaPaths(cwd).prisma });
await generator.generate();
generator.stop();
} finally {
predefinedGeneratorResolvers['prisma-client-js'] = prevPredefinedGeneratorResolver;
}
}

export function requirePrismaClient(cwd: string) {
Expand Down