Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused name from Auth session documentation #7533

Merged
merged 2 commits into from Aug 10, 2022

Conversation

Greenheart
Copy link

Quick fix to make the code sample in the guide work as expected.

The auth guide now consistently uses id instead of mentioning id but actually using name like it did in a previous commit https://github.com/keystonejs/keystone/blob/d0713111f1cdb76d553eb0d65a597620e0d3e056/docs/pages/docs/guides/auth-and-access-control.mdx#add-a-sessiondata-query

This is such a small change so I thought no changeset was needed, but let me know if that's required, and I'll update the PR.

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2022

⚠️ No Changeset found

Latest commit: 5adcda2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview May 31, 2022 at 2:42AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview May 14, 2022 10:38 Inactive
@dcousens dcousens enabled auto-merge (squash) May 31, 2022 02:40
@dcousens dcousens changed the title Fix auth session docs Remove unused name from Auth session documentation May 31, 2022
@vercel vercel bot temporarily deployed to Preview May 31, 2022 02:42 Inactive
@dcousens dcousens disabled auto-merge August 10, 2022 07:35
@dcousens dcousens merged commit f5bf41a into keystonejs:main Aug 10, 2022
@Greenheart Greenheart deleted the fix/auth-session-docs branch August 10, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants