Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keystone display images on website #7564

Merged
merged 6 commits into from May 30, 2022

Conversation

mattbx
Copy link
Contributor

@mattbx mattbx commented May 25, 2022

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

⚠️ No Changeset found

Latest commit: a81569f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview May 30, 2022 at 4:18AM (UTC)

@vercel vercel bot temporarily deployed to Preview May 25, 2022 22:38 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@raveling raveling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

the "why keystone" image needs to be a transparent PNG in order to render properly when the website is set to dark mode.

image

@dcousens dcousens changed the title updated images Update Keystone display images on website May 26, 2022
@vercel vercel bot temporarily deployed to Preview May 30, 2022 00:25 Inactive
@mattbx mattbx changed the base branch from main to website_live May 30, 2022 00:27
@mattbx mattbx requested a review from raveling May 30, 2022 00:59
@vercel vercel bot temporarily deployed to Preview May 30, 2022 02:55 Inactive
@vercel vercel bot temporarily deployed to Preview May 30, 2022 03:16 Inactive
Revised with feedback from Ron
Corrected new image dimensions
@vercel vercel bot temporarily deployed to Preview May 30, 2022 03:56 Inactive
@vercel vercel bot temporarily deployed to Preview May 30, 2022 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview May 30, 2022 04:18 Inactive
Copy link
Contributor

@raveling raveling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raveling raveling merged commit b722a7f into website_live May 30, 2022
@raveling raveling deleted the marketing-image-revisions branch May 30, 2022 04:23
dcousens pushed a commit that referenced this pull request Jun 2, 2022
* updated images

Site images updated based on

keystonejs/keystone-private#83

* revisions

Revised with feedback from Ron

* Image dimensions corrected

Corrected new image dimensions

* updated images

Site images updated based on

keystonejs/keystone-private#83

* Updated content management UI image

* Update data-integrity.png

Co-authored-by: Ronald Aveling <luma.chroma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants