Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field descriptions #7578

Merged
merged 9 commits into from
Jun 10, 2022
Merged

Add field descriptions #7578

merged 9 commits into from
Jun 10, 2022

Conversation

Achisingh
Copy link
Contributor

@Achisingh Achisingh commented Jun 1, 2022

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 2bb0a74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@keystone-ui/fields Minor
@keystone-6/cloudinary Major
@keystone-6/core Minor
@keystone-6/fields-document Major
@keystone-6/auth Major
@keystone-6/session-store-redis Major
@keystone-6/website Patch
@keystone-6/examples-app-basic Patch
@keystone-6/example-graphql-api-endpoint Patch
@keystone-6/example-document-field Patch
@keystone-6/sandbox Patch
@keystone-6/example-auth Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-roles Patch
@keystone-6/example-testing Patch
@keystone-6/example-with-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 0:40AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bb0a74:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview June 1, 2022 00:48 Inactive
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the fields should render the description, currently only the text and cloudinary fields are

Co-authored-by: Mitchell Hamilton <mitchellhamilton@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview June 7, 2022 13:05 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2022 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2022 03:05 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2022 03:40 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2022 05:06 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2022 05:23 Inactive
Copy link
Contributor

@raveling raveling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Please see inline suggestions and comments.

We're still missing descriptions in some of the ui variants for relationship and select fieldtypes

image

image

packages/core/src/fields/types/checkbox/views/index.tsx Outdated Show resolved Hide resolved
design-system/packages/fields/src/FieldDescription.tsx Outdated Show resolved Hide resolved
design-system/packages/fields/src/FieldDescription.tsx Outdated Show resolved Hide resolved
@dcousens dcousens mentioned this pull request Jun 9, 2022
@dcousens dcousens assigned Achisingh and unassigned Achisingh Jun 9, 2022
@vercel vercel bot temporarily deployed to Preview June 9, 2022 08:03 Inactive
@raveling
Copy link
Contributor

raveling commented Jun 9, 2022

This is looking really good 🙌

One more thing. Now that we have field descriptions in the card displayMode of the relationship field, I feel that we should solve the broader whitespace issues that exist in the cards UI. This gap is too large to associate the action buttons with the field label and description.

image

@emmatown
Copy link
Member

One more thing. Now that we have field descriptions in the card displayMode of the relationship field, I feel that we should solve the broader whitespace issues that exist in the cards UI. This gap is too large to associate the action buttons with the field label and description.

Let's deal with that in a different PR

@vercel vercel bot temporarily deployed to Preview June 10, 2022 00:35 Inactive
@vercel vercel bot temporarily deployed to Preview June 10, 2022 00:40 Inactive
@Achisingh
Copy link
Contributor Author

Looking good! Please see inline suggestions and comments.

We're still missing descriptions in some of the ui variants for relationship and select fieldtypes

image

image

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants