Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fields): fix calendarDay non-nullable input type name #7866

Merged
merged 2 commits into from Aug 31, 2022

Conversation

acburdine
Copy link
Contributor

@acburdine acburdine commented Aug 30, 2022

I'm relatively certain this will fix the issue I reported in #7865, but there could be other reasons it was occurring. This just appeared to be the most obvious one.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: af76c3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-6/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 0:49AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af76c3a:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview August 30, 2022 14:16 Inactive
@acburdine
Copy link
Contributor Author

tested this with the repro example I added in #7865 - can confirm this does fix the issue

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vercel vercel bot temporarily deployed to Preview August 31, 2022 00:49 Inactive
@dcousens
Copy link
Member

dcousens commented Aug 31, 2022

Thanks @acburdine 💙 - this is great

@dcousens dcousens enabled auto-merge (squash) August 31, 2022 01:03
@dcousens dcousens merged commit e84fb87 into keystonejs:main Aug 31, 2022
@acburdine acburdine deleted the fix/calendarday-types branch August 31, 2022 03:26
dcousens pushed a commit that referenced this pull request Sep 14, 2022
* fix(fields): fix calendarDay non-nullable input type name

* Update .changeset/tasty-lies-move.md

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
dcousens pushed a commit that referenced this pull request Sep 15, 2022
* fix(fields): fix calendarDay non-nullable input type name

* Update .changeset/tasty-lies-move.md

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
dcousens pushed a commit that referenced this pull request Sep 15, 2022
* fix(fields): fix calendarDay non-nullable input type name

* Update .changeset/tasty-lies-move.md

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
dcousens pushed a commit that referenced this pull request Sep 15, 2022
* fix(fields): fix calendarDay non-nullable input type name

* Update .changeset/tasty-lies-move.md

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple CalendarDay fields in a single List causes a schema build error
3 participants