Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limiting in CI #7875

Merged
merged 3 commits into from Aug 31, 2022
Merged

Fix rate limiting in CI #7875

merged 3 commits into from Aug 31, 2022

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Aug 31, 2022

I think this should fix the rate limiting we're seeing because if you look at the logs, it always fails in actions/setup-node right after it logs Attempt to resolve LTS alias from manifest...(https://github.com/actions/setup-node/blob/c2dfe2df9884bf1033e0ee352d86309105ea6cf0/src/installer.ts#L44) that leads to https://github.com/actions/toolkit/blob/500d0b42fee2552ae9eeb5933091fe2fbf14e72d/packages/tool-cache/src/tool-cache.ts#L589 which does a GitHub API call so getting a rate limit error from GitHub makes sense.

So I think we can fix it by writing a version rather than use lts/*, from a cursory reading of the code in actions/setup-node doesn't try to do a call to GitHub's API when using a version range like 16. Updating our CI every time there is a new active Node LTS seems fine.

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 5:54AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

⚠️ No Changeset found

Latest commit: 50ef018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50ef018:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview August 31, 2022 05:41 Inactive
@emmatown emmatown marked this pull request as ready for review August 31, 2022 05:42
@emmatown emmatown requested a review from a team August 31, 2022 05:43
@dcousens
Copy link
Member

What a pain, but I understand

@vercel vercel bot temporarily deployed to Preview August 31, 2022 05:51 Inactive
@dcousens dcousens enabled auto-merge (squash) August 31, 2022 05:52
@vercel vercel bot temporarily deployed to Preview August 31, 2022 05:54 Inactive
@dcousens dcousens merged commit ba32b2b into main Aug 31, 2022
@dcousens dcousens deleted the fix-ci-rate-limit branch August 31, 2022 06:03
dcousens added a commit that referenced this pull request Sep 14, 2022
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
dcousens added a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
dcousens added a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
dcousens added a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants