Unify access-control errors, and fix access-control types #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
commented
Sep 12, 2022
dcousens
commented
Sep 12, 2022
dcousens
commented
Sep 12, 2022
dcousens
commented
Sep 12, 2022
dcousens
commented
Sep 12, 2022
dcousens
force-pushed
the
access-control-types
branch
from
c475f9f
to
523ce60
Compare
dcousens
force-pushed
the
access-control-types
branch
from
523ce60
to
be5e789
Compare
dcousens
force-pushed
the
access-control-types
branch
from
6ca572b
to
4d9de0c
Compare
dcousens
force-pushed
the
access-control-types
branch
2 times, most recently
from
b24745b
to
22b47dd
Compare
dcousens
force-pushed
the
access-control-types
branch
from
c2d7e89
to
73e8fe0
Compare
dcousens
force-pushed
the
access-control-types
branch
from
1be4d61
to
811b94d
Compare
dcousens
force-pushed
the
access-control-types
branch
from
811b94d
to
355929a
Compare
dcousens
force-pushed
the
access-control-types
branch
from
0eb5851
to
db890cd
Compare
dcousens
changed the title
emmatown
approved these changes
Oct 6, 2022
emmatown
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request unifies most access-control errors to the following two messages:
This removes the burden of stringifying the
inputDataor the user provided filters in different scenarios.That shouldn't be a problem, but, we can eliminate that risk with this.
The only differentiation of routine error types now is between list and fields.
This pull request additionally fixes a few unreleased type problems that were merged in #7848.