Prefer isSingleton, not a singleton function #7941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
singleton
function in favour of users configuring the list instead, withisSingleton
.We are opting to AVOID discretizing
list
into two discriminated types.By introducing a
singleton
function, we may be confusing users into thinking that these are not actually lists.Instead, users shouldn't have any confusion about whether a list with
isSingleton: true
is still simply a list.When configured, the list simply has the following added behaviour traits that revolve around the list containing only 1 item (id: 1):
create
or the item withid: 1
id: 1
for reduce verbosity when using singletons