Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for withRequest #8104

Merged
merged 7 commits into from Nov 23, 2022
Merged

Update documentation for withRequest #8104

merged 7 commits into from Nov 23, 2022

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Nov 20, 2022

An emphasis should be made to distinguish the common, public, generic context that is provided to onConnect, extendExpressApp, extendHttpServer from the specific context's (that typically have a session) that are provided to hooks and access control.

In this pull request, we are using commonContext, but other ideas might be

  • publicContext
  • genericContext (might be confusing this idea with Typescript)
  • baseContext
  • commonContext

Follow up to

@changeset-bot

This comment was marked as resolved.

@vercel
Copy link

vercel bot commented Nov 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 2:58AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca53771:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview November 20, 2022 23:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 21, 2022 00:22 Inactive
@vercel vercel bot temporarily deployed to Preview November 21, 2022 00:31 Inactive
@vercel vercel bot temporarily deployed to Preview November 21, 2022 00:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 21, 2022 00:55 Inactive
@borisno2 borisno2 marked this pull request as ready for review November 21, 2022 01:37
@borisno2 borisno2 marked this pull request as draft November 21, 2022 01:59
@borisno2 borisno2 marked this pull request as ready for review November 21, 2022 02:51
@vercel vercel bot temporarily deployed to Preview November 21, 2022 02:53 Inactive
@vercel vercel bot temporarily deployed to Preview November 21, 2022 02:58 Inactive
@dcousens dcousens merged commit f22bbc7 into main Nov 23, 2022
@dcousens dcousens deleted the update-context-docs branch November 23, 2022 02:55
@dcousens dcousens mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants