(re)Add support for publicPage redirects using pageMiddleware #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c4ec74:
|
dcousens
force-pushed
the
public-redirects
branch
from
d0c087a
to
c63e0cb
Compare
borisno2
approved these changes
Jan 30, 2023
…ort for public redirects
dcousens
force-pushed
the
public-redirects
branch
from
6792c29
to
2ce0eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8115 removed support for
pageMiddlewarebeing called forpublicPages, as it was determined that the existing behaviour was error-prone as written as a result of the dynamic betweenisAccessAllowedandpageMiddlewareas written.This pull request re-introduces support for
pageMiddlewareto be used forpublicPagesby renaming the boolean flagisValidSessiontowasAccessAllowed. This removes the ambiguity that this flag related to anything except theisAccessAllowedfunction.When calling
pageMiddleware,wasAccessAllowedis always true for pages that are in thepublicPagesarray.isAccessAllowedis NOT called for public pages.