Fix withRequest behavior without session strategy #8318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keystonejs#8317 - previously, if no session strategy was configured in the Keystone config, the withRequest function would return early without calling `createContext`. If `sudo()` was called on the returned context from withRequest, the context object returned from sudo would have the req/res objects present on the initial context object (i.e. the one prior to withRequest being called) - this change makes withRequest consistent with the other context 'change' functions (sudo/exitSudo/withSession)
This comment was marked as resolved.
This comment was marked as resolved.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a91670:
|
acburdine
commented
Feb 16, 2023
|
also, I tried finding a good place to add tests for this edge case but didn't see any obvious spots to put it 😬 If there's a "correct" place to write tests for this let me know and I'll gladly add them 😄 |
dcousens
approved these changes
Feb 17, 2023
|
Failing tests is unrelated, this looks good to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8317
createContext. Ifsudo()was called on the returned context from withRequest, the context object returned from sudo would have the req/res objects present on the initial context object (i.e. the one prior to withRequest being called)