Fix broken context type narrowing for virtual field resolvers #8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d080a8:
|
dcousens
force-pushed
the
fix/virtual-field-session
branch
from
1038afc
to
8df72d5
Compare
dcousens
approved these changes
Aug 8, 2023
dcousens
force-pushed
the
fix/virtual-field-session
branch
from
8df72d5
to
2835b5d
Compare
|
Thanks @acburdine, I added a (previously) broken example that should help prevent a regression too 💚 |
dcousens
force-pushed
the
fix/virtual-field-session
branch
from
1f57910
to
1d080a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8740
graphql.Fieldsupports the context type as a passthrough, so this PR passes through the inferred Context type.Tested this via patch-package, it fixed the issue I had in #8740, though I'm not sure if there are other side-effects this type passthrough would have 🤔