New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop p-limit
internally
#8809
Drop p-limit
internally
#8809
Conversation
f8bd14a
to
c427408
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85b2a1d:
|
c6501c3
to
336db68
Compare
Although this pull request removes the internal As reported in the following issues to prisma:
To prevent broken behaviour, especially in our tests, we need Prisma to internally queue the sqlite "connections". |
9c55746
to
8ba1162
Compare
81d7401
to
4c00768
Compare
if (x === true) return 'True' | ||
if (x === false) return 'False' | ||
return 'Undefined' | ||
if (x === true) return 'T' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shortened the strings to work within database limitations
async findMany () { | ||
return [{ id: 'mock' }] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incompatible with how we are using Prisma now, and probably Prisma 5 too
9b3fa77
to
33eaa7e
Compare
for (const create of [undefined, 'create']) { | ||
for (const update of [undefined, 'update']) { | ||
for (const _delete of [undefined, 'delete']) { | ||
const omit = [query, create, update, _delete].filter(x => x) as ListConfig['omit'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was completely broken
33eaa7e
to
85b2a1d
Compare
This pull request should remove the use of
p-limit
internally for limitingPrisma
engine operations.prisma/prisma#2955 has been resolved, and - at least as documented - this was the only reason this approach was taken.