Tidy up Cloudinary package and add missing changeset #8836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Sep 26, 2023
| ...config | ||
| }: CloudinaryImageFieldConfig<ListTypeInfo>): FieldTypeFunc<ListTypeInfo> => | ||
| meta => { | ||
| // TODO: no delete support |
There was a problem hiding this comment.
This field implicitly preserves the images that are uploaded, as mentioned in #8816 (comment), we should align this field with the storage approaches we have elsewhere - or at least revisit that design
dcousens
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f19e2c9:
|
dcousens
force-pushed
the
cloudinary-fixes
branch
from
04bcdec
to
f19e2c9
Compare
borisno2
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8816 made a patch change to the
@keystone-6/cloudinarypackage, but a.changeset/entry was not added.This pull request adds the missing entry and additionally inlines the
cloudinary.tsadapter into the field, reducing the complexity of the package.