Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search by relations fields #8966

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

pnodet
Copy link
Contributor

@pnodet pnodet commented Dec 15, 2023

Allow admin users inside a list page to search by relations text fields

Copy link

codesandbox-ci bot commented Dec 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f44af9:

Sandbox Source
@keystone-6/sandbox Configuration

@pnodet
Copy link
Contributor Author

pnodet commented Dec 18, 2023

Hi @dcousens I see some tests failing but some are due to CI setup failure I think, not sure what to do tbh

@dcousens
Copy link
Member

Thanks @pnodet, I'll check that out as soon as I can

@pnodet
Copy link
Contributor Author

pnodet commented Jan 2, 2024

HNY @dcousens thanks for the formatting commit!
I this PR something you are interested in? do you think this will get merged or I better publish a npm fork?

@pnodet
Copy link
Contributor Author

pnodet commented Jan 25, 2024

@dcousens from the 58 tests the failing one seem to be related to tsx, not sure how to fix tbh

> @keystone-6/example-testing@0.0.8 test /home/runner/work/keystone/keystone/examples/testing
> node --loader tsx example-test.ts


node:internal/process/esm_loader:40
      internalBinding('errors').triggerUncaughtException(
                                ^
Error: tsx must be loaded with --import instead of --loader
The --loader flag was deprecated in Node v20.6.0

@dcousens
Copy link
Member

dcousens commented Jan 25, 2024

@pnodet happy new years to you too 💛

I'm not convinced this will be intuitive and could result in unexpected performance costs in some usecases.
Can the user opt-in to the behavior?

@pnodet
Copy link
Contributor Author

pnodet commented Jan 25, 2024

@dcousens

By user you mean end-user (ie: a checkbox with label Activate search by relation fields) or keystone user the developers in the schema for example?

@dcousens
Copy link
Member

dcousens commented Jan 25, 2024

sorry, I mean developer (but, maybe the user too...)

@pnodet
Copy link
Contributor Author

pnodet commented Jan 29, 2024

Sure, for the developer we could have something in the schema / list. Inside the relationship field there is already a isFilterable and isOrderable properties if I'm not mistaken. I'm not an expert and I don't quite remember how we use them but I imagine we could have another field like isSearchable for exemple, defaults to false for backward compatibility.

@pnodet
Copy link
Contributor Author

pnodet commented Mar 14, 2024

Hi @dcousens What do you have in mind? anything I can do to get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants