Use node 20 in CI and fix testing example #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 028b984:
|
borisno2
force-pushed
the
fix-testing-example-test
branch
from
ca79389
to
c312a1d
Compare
borisno2
changed the title
tsx directly for test exampletsx directly for testing example
borisno2
changed the title
tsx directly for testing exampletsx directly for testing example
borisno2
changed the title
tsx directly for testing exampletsx directly for testing example
dcousens
reviewed
Dec 21, 2023
borisno2
changed the title
tsx directly for testing example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been
node --loaderoriginally due to an issue with node 18, however with the upgrade to node18.19the--loaderwhich was experimental is depreciated sotsxis throwing an error for the testing example.This PR bumps the CI to use node 20 (latest lts) and also fixes the testing example to use
--import.