Remove deprecated config.db.useMigrations, change keystone prisma behaviour#9090
Merged
Remove deprecated config.db.useMigrations, change keystone prisma behaviour#9090
config.db.useMigrations, change keystone prisma behaviour#9090Conversation
dcousens
commented
Apr 11, 2024
|
|
||
| if (command === 'start') { | ||
| return start(cwd, defaultFlags(flags, { ui: true, withMigrations: false })) | ||
| return start(cwd, defaultFlags(flags, { server: true, ui: true, withMigrations: false })) |
Member
Author
There was a problem hiding this comment.
start --with-migrations --no-server might be redundant by comparison to keystone prisma migrate deploy, but, I think start --no-server being ignored is worse
dcousens
commented
Apr 11, 2024
| }) | ||
| } | ||
|
|
||
| export async function devMigrations ( |
Member
Author
There was a problem hiding this comment.
Use keystone prisma migrate dev instead
951fd81 to
e90447e
Compare
This was referenced Apr 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes
config.db.useMigrations, which was deprecated in #8046, but perhaps a better description of why is needed to help with updating your workflow.I'll add a draft of that workflow here into our documentation soon.
The short of it could probably be summarised in the following text (work in progress):
Any feedback is appreciated, as we move to integrate this workflow into the documentation.
References