This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Test on Python 3.6 in allow_failures mode #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake8 [finds different errors](http://flake8.pycqa.org/en/latest/user/invocation.html) on Python 2 and Python 3. In general, if code passes on Python 3 then it will probably pass on Python 2 as well. But the opposite is not true. My recommendation would be that you run on both Python 2 and 3 just to be sure or that you run on Python 3 only. Here we have set Python 3 testing to run in __allow_failures__ mode so that we can see the open issues but the overall test will still be green.
|
My original thought was checking out a new branch to do the migration to Python 3, and using separate .travis.yml to test on the two branches individually, I'm quite new to travis-ci, your solution would be a better choice I think. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 finds different errors on Python 2 and Python 3. In general, if code passes on Python 3 then it will probably pass on Python 2 as well. But the opposite is not true. My recommendation would be that you run on both Python 2 and 3 just to be sure or that you run on Python 3 only. Here we have set Python 3 testing to run in allow_failures mode so that we can see the open issues but the overall test will still be green.
https://travis-ci.org/kezhenxu94/house-renting/builds/385662266