feat: add square wave latency summand #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kffl
requested changes
Aug 2, 2022
Comment on lines
+144
to
+156
| var conn *net.TCPConn | ||
|
|
||
| // Wait for the speedbump instance to start listening | ||
| // since it is started in a separate goroutine, we don't know | ||
| // if it has already started listening by this point | ||
| for { | ||
| conn, err = net.DialTCP("tcp", nil, tcpAddr) | ||
| if err != nil { | ||
| time.Sleep(10 * time.Millisecond) | ||
| } else { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
This test bug was causing the CI pipeline to fail every once in a while. Thanks for fixing it.
On a side note, it shows that the public API could be a bit more intuitive (i.e. Start() that returns immediately after the proxy starts listening). Such changes will likely be introduced in v1 due to their breaking nature.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a square wave latency summand. Since the
TestSpeedbumpWithEchoServerwas sometimes failing, I've also added a loop retrying TCP dials in case the proxy in a separate goroutine hasn't started listening yet.Resolves #16