Fix processing of escape sequences so we don't forget about \r. This …

…avoids OBOEs when generating diagnostics. Also, this OBOE could cause a panic/ICE if we end up offcut in the middle of a UTF-8 sequence.
kfitch · Apr 6, 2020 · 972560b · 972560b
1 parent 4015890
commit 972560b
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/librustc_builtin_macros/format.rs b/src/librustc_builtin_macros/format.rs
@@ -918,6 +918,9 @@ pub fn expand_preparsed_format_args(
                     skips.push(*next_pos);
                     let _ = s.next();
                 }
+
+                // TODO: Should this include:
+                // | ('\\', Some((next_pos, 'r')))
                 ('\\', Some((next_pos, '\n')))
                 | ('\\', Some((next_pos, 'n')))
                 | ('\\', Some((next_pos, 't')))
@@ -927,10 +930,14 @@ pub fn expand_preparsed_format_args(
                     skips.push(*next_pos);
                     let _ = s.next();
                 }
+
+                // TODO: Should this include ('\r'), what about other weird
+                // whitespace like vertical tab? 
                 (' ', _) | ('\n', _) | ('\t', _) if eat_ws => {
                     skips.push(pos);
                 }
                 ('\\', Some((next_pos, 'n')))
+                | ('\\', Some((next_pos, 'r')))
                 | ('\\', Some((next_pos, 't')))
                 | ('\\', Some((next_pos, '0')))
                 | ('\\', Some((next_pos, '\\')))