Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newly introduced ExpressionMap as domain for execution, return, and returnMap #16

Closed
pmaria opened this issue Mar 30, 2023 · 11 comments
Assignees

Comments

@pmaria
Copy link

pmaria commented Mar 30, 2023

With the introduction of rml:ExpressionMap, the domain of rml:execution , rml:return, and rml:returnMap, should now be changed to rml:ExpressionMap.
This makes functions applicable on anything that is an rml:ExpressionMap , like rml:DatatypeMap, rml:LanguageMap etc.

@bjdmeest
Copy link
Member

@pmaria are we supposed to call it 'function-valued expression map' then as well?

@bjdmeest
Copy link
Member

Then the overall diagram would also change I assume

@pmaria
Copy link
Author

pmaria commented Apr 26, 2023

yes, i think so

@bjdmeest
Copy link
Member

@anaigmo

@anaigmo
Copy link
Contributor

anaigmo commented Apr 26, 2023

@pmaria are we supposed to call it 'function-valued expression map' then as well?

I'm confused by this statement, do you mean by this to introduce also a subclass of ExpressionMap called like that?

@bjdmeest
Copy link
Member

We should be able to use a function when creating, e.g., the language tag, can you estimate how this affects the current diagram @anaigmo ? I would expect that all lines that currently go from FNML to TermMap as I see them at ontology/RML diagrams-RML-overview.png should actually go to ExpressionMap. But I could be wrong :)

@anaigmo
Copy link
Contributor

anaigmo commented Apr 27, 2023

Oki let's see; there are two options:

  1. We go for ExpressionMap for everything: All terms that previously were subclass of TermMap, now they are of ExpressionMap

RML-diagram-RML (Functions)

  1. We only change the domains of returnMap, return and execution; leaving the rest with termMap

RML-diagram-RML (Functions) (1)

(Note that in the diagrams I'm not showing the shortcuts, but I take them into account for the OWL)

Please confirm which option makes more sense, and I'll change the corresponding resources

@bjdmeest
Copy link
Member

bjdmeest commented May 8, 2023

The latter makes most sense imo, and is in line with what @pmaria said, so I vote for 2! :D

@samiscoding
Copy link
Collaborator

The second diagram makes more sense to me too!

@bjdmeest
Copy link
Member

TODO @bjdmeest fix the spec wording

@bjdmeest
Copy link
Member

bjdmeest commented Nov 8, 2023

So, this was already fixed 🙈

@bjdmeest bjdmeest closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants