Rewrite helper in C++ for significant speed boost #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on Ubuntu, unlocking the screen freezes for several seconds while waiting for the `pa_helper` script to run at least 10 times. Rewriting it in C++ means that each run take about 0.002 seconds (on my machine) instead of about 0.2 seconds for the Python script.
This was referenced Dec 12, 2022
|
Thanks for the support. I am not merging this PR now, as there were some guidelines against distributing binaries. I am really outdated now, so I will check for the latest guidelines and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on Ubuntu, unlocking the screen freezes for several seconds while waiting for the
pa_helperscript to run at least 10 times. Rewriting it in C++ means that each run take about 0.002 seconds (on my machine) instead of about 0.2 seconds for the Python script. This fixes #261, #257, and #246.