Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a crash that happened when locking the screen. #43

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

broo2s
Copy link
Contributor

@broo2s broo2s commented Sep 14, 2018

This extension crashed for me on Ubuntu 18.04 whenever I locked the screen and sometimes randomly. I found out this was due to "port.profiles is undefined" error, described in #26 and #27.

My fix is very naive, it may not be a perfect solution. It works for me so far and it should not break anything more than it is right now.

The error was: "port.profiles is undefined".
@lestcape
Copy link

This is a workaround to this problem:
https://bugzilla.gnome.org/show_bug.cgi?id=783578

Also please see a related issue at a higher level in gjs:
https://gitlab.gnome.org/GNOME/gjs/issues/109

@kgshank kgshank merged commit 59aedcc into kgshank:master Oct 18, 2018
@kgshank
Copy link
Owner

kgshank commented Oct 18, 2018

@lestcape I hope the bug is resolved, I had to resort to ugly solution because of the same problem

@lestcape
Copy link

@kgshank Sorry, but i don't think that it will be resolved soon. The original Bugzilla issue of libgnome-volume-control was not migrate to gitlab. So, it was forgot in the migration and not one care about it because libgnome-volume-control is a private library in gnome-shell. So, they fix only what they use and not care to be fully functional, because is not public.

For the another hand in gjs this was accepted as a feature request , not as a bug. This is because in gjs is not a bug really how occurs in libgnome-volume-control. A feature request in a gjs will have not priority at all, because of the big complexity of the project and the few people working on it ensure that probably only bugs will be resolved and not features request. So, probably will never be resolved also there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants