Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct use of either_dict_or_kwargs() in AttrSeries.sel() #52

Merged
merged 8 commits into from
Nov 23, 2021

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Nov 23, 2021

The third argument gives the name of the method, not the argument. This improves the error message shown when the function is miscalled.

Also:

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

Third argument gives the name of the method, not the argument.
@khaeru khaeru self-assigned this Nov 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #52 (38c8fe8) into main (3bfb54d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2599      2597    -2     
=========================================
- Hits          2599      2597    -2     
Impacted Files Coverage Δ
genno/tests/core/test_exceptions.py 100.00% <ø> (ø)
genno/caching.py 100.00% <100.00%> (ø)
genno/core/attrseries.py 100.00% <100.00%> (ø)
genno/testing.py 100.00% <100.00%> (ø)
genno/tests/core/test_computer.py 100.00% <100.00%> (ø)
genno/tests/test_caching.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfb54d...38c8fe8. Read the comment docs.

@khaeru khaeru merged commit 0e07739 into main Nov 23, 2021
@khaeru khaeru deleted the hotfix/sel-args branch November 23, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants