Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arbitrary module names and modules objects in require_compat() #63

Merged
merged 2 commits into from
May 5, 2022

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Apr 26, 2022

As described.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added the enh New feature or request label Apr 26, 2022
@khaeru khaeru self-assigned this Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #63 (8753052) into main (c5a198c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2796      2809   +13     
=========================================
+ Hits          2796      2809   +13     
Impacted Files Coverage Δ
genno/core/computer.py 100.00% <100.00%> (ø)
genno/tests/core/test_computer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a198c...8753052. Read the comment docs.

@khaeru khaeru merged commit 5be9268 into main May 5, 2022
@khaeru khaeru deleted the enh/require-compat branch May 5, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants