Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Computer.eval() #97

Merged
merged 20 commits into from
Aug 17, 2023
Merged

Add Computer.eval() #97

merged 20 commits into from
Aug 17, 2023

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Aug 16, 2023

  • Add a method Computer.eval() that allows to define tasks and keys using a subset of Python syntax.
  • Add .computations.sub.
  • Test and close some small bugs (see sidebar).

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added the enh New feature or request label Aug 16, 2023
@khaeru khaeru self-assigned this Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #97 (87e8c49) into main (0f577d2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main       #97    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           42        43     +1     
  Lines         3383      3524   +141     
==========================================
+ Hits          3383      3524   +141     
Files Changed Coverage Δ
genno/compat/xarray.py 100.00% <100.00%> (ø)
genno/computations.py 100.00% <100.00%> (ø)
genno/core/attrseries.py 100.00% <100.00%> (ø)
genno/core/computer.py 100.00% <100.00%> (ø)
genno/core/eval.py 100.00% <100.00%> (ø)
genno/core/key.py 100.00% <100.00%> (ø)
genno/testing/__init__.py 100.00% <100.00%> (ø)
genno/tests/core/test_attrseries.py 100.00% <100.00%> (ø)
genno/tests/core/test_computer.py 100.00% <100.00%> (ø)
genno/tests/core/test_quantity.py 100.00% <100.00%> (ø)
... and 1 more

@khaeru khaeru linked an issue Aug 17, 2023 that may be closed by this pull request
@khaeru khaeru merged commit 0d4a75e into main Aug 17, 2023
14 checks passed
@khaeru khaeru deleted the enh/eval branch August 31, 2023 21:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
2 participants