forked from dr-leo/pandaSDMX
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance writer.xml to round-trip DataMessages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
added
enh
Enhancements & new features
writer
Convert objects to other formats
xml
SDMX-ML format
labels
Aug 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 94.06% 94.12% +0.06%
==========================================
Files 51 51
Lines 4063 4139 +76
==========================================
+ Hits 3822 3896 +74
- Misses 241 243 +2
Continue to review full report at Codecov.
|
- ECB_EXR/1/M.USD.EUR.SP00.A.xml is used as a test case.
- Also add a table of contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #7.
compare()
methods.compare()
methods.writer.xml
gives intelligible/NotImplemented errors for unsupported messages.