Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance writer.xml to round-trip DataMessages #13

Merged
merged 11 commits into from Aug 17, 2020
Merged

Enhance writer.xml to round-trip DataMessages #13

merged 11 commits into from Aug 17, 2020

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Aug 2, 2020

Will close #7.

  • Complete new compare() methods.
  • Document new compare() methods.
  • Test >1 other DataMessage; ensure writer.xml gives intelligible/NotImplemented errors for unsupported messages.
  • Update What's new.

@khaeru khaeru added enh Enhancements & new features writer Convert objects to other formats xml SDMX-ML format labels Aug 2, 2020
@khaeru khaeru self-assigned this Aug 2, 2020
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #13 into master will increase coverage by 0.06%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   94.06%   94.12%   +0.06%     
==========================================
  Files          51       51              
  Lines        4063     4139      +76     
==========================================
+ Hits         3822     3896      +74     
- Misses        241      243       +2     
Impacted Files Coverage Δ
sdmx/tests/test_model.py 100.00% <ø> (ø)
sdmx/message.py 97.53% <90.00%> (-1.10%) ⬇️
sdmx/writer/xml.py 98.21% <98.30%> (+0.01%) ⬆️
sdmx/model.py 96.66% <100.00%> (+0.02%) ⬆️
sdmx/reader/sdmxml.py 97.01% <100.00%> (ø)
sdmx/tests/data/__init__.py 97.82% <100.00%> (ø)
sdmx/tests/writer/test_writer_xml.py 100.00% <100.00%> (ø)
sdmx/writer/base.py 95.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d55dd...8a01e98. Read the comment docs.

@khaeru khaeru merged commit 6948839 into master Aug 17, 2020
@khaeru khaeru deleted the issue/7 branch August 17, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancements & new features writer Convert objects to other formats xml SDMX-ML format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round-trip at least 1 kind of DataMessage
1 participant