Fix #149

[khaeru]

Closes #149.

PR checklist

• Checks all ✅
• Update documentation Bugfix only.
• Update doc/whatsnew.rst

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c56574a) 98.33% compared to head (fc8fc0e) 95.97%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   98.33%   95.97%   -2.37%     
==========================================
  Files          87       87              
  Lines        6443     6480      +37     
==========================================
- Hits         6336     6219     -117     
- Misses        107      261     +154     

Files	Coverage Δ
sdmx/model/common.py	99.89% <100.00%> (+<0.01%)	⬆️
sdmx/reader/xml/v21.py	97.70% <100.00%> (-0.12%)	⬇️
sdmx/testing/__init__.py	99.28% <ø> (ø)
sdmx/tests/writer/test_writer_xml.py	100.00% <100.00%> (ø)
sdmx/writer/xml.py	97.66% <98.52%> (+0.08%)	⬆️

... and 18 files with indirect coverage changes

[khaeru]

@goatsweater please let me know if you are able to check this branch against any other examples beyond the specimen you shared in #149. Meanwhile I will complete the PR checklist and prepare to merge/release.

[goatsweater]

I'll run it against some of our production data tomorrow and let you know how things go.

[goatsweater]

Overall things look good. I did notice that ConceptIdentity references are now getting a version="1.0" when no version was supplied in the source. Nothing else unexpected noticed.

Output:

<str:ConceptIdentity>
  <Ref agencyID="AGENCYID" id="AUX2" maintainableParentID="CS_SAMPLE_BETA" maintainableParentVersion="1.0" version="1.0" package="conceptscheme" class="Concept"/>
</str:ConceptIdentity>

Source:

<structure:ConceptIdentity>
  <Ref id="AUX2" maintainableParentID="CS_SAMPLE_BETA" maintainableParentVersion="1.0" agencyID="AGENCYID" package="conceptscheme" class="Concept" />
</structure:ConceptIdentity>

[khaeru]

Great, thanks.

It doesn't make sense that a non-maintainable individual item (e.g. Concept) has a version="..."; only the maintainableParentVersion="…" for the ConceptScheme or similar should be there.

I'll check and address that, then merge and release.