Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdmx.__version__ bug #68 #69

Merged
merged 1 commit into from Mar 9, 2021
Merged

Conversation

miccoli
Copy link

@miccoli miccoli commented Mar 9, 2021

Variable sdmx.version is initialised with
'pkg_resources.get_distribution' using the appropriate
Distribution Package name 'sdmx1'.

Variable sdmx.__version__ is initialised with
'pkg_resources.get_distribution' using the appropriate
Distribution Package name 'sdmx1'.
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #69 (01d3a2a) into master (3e4cbc1) will decrease coverage by 2.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   96.94%   94.67%   -2.28%     
==========================================
  Files          53       53              
  Lines        4393     4393              
==========================================
- Hits         4259     4159     -100     
- Misses        134      234     +100     
Impacted Files Coverage Δ
sdmx/__init__.py 84.61% <100.00%> (-15.39%) ⬇️
sdmx/source/wb_wdi.py 28.57% <0.00%> (-71.43%) ⬇️
sdmx/source/ilo.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/lsd.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/insee.py 57.14% <0.00%> (-42.86%) ⬇️
sdmx/source/istat.py 57.14% <0.00%> (-42.86%) ⬇️
sdmx/source/estat.py 47.50% <0.00%> (-42.50%) ⬇️
sdmx/source/sgr.py 50.00% <0.00%> (-40.00%) ⬇️
sdmx/source/wb.py 66.66% <0.00%> (-33.34%) ⬇️
sdmx/tests/test_sources.py 71.31% <0.00%> (-28.69%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4cbc1...01d3a2a. Read the comment docs.

@khaeru khaeru linked an issue Mar 9, 2021 that may be closed by this pull request
@khaeru khaeru merged commit 80f19e3 into khaeru:master Mar 9, 2021
@khaeru
Copy link
Owner

khaeru commented Mar 9, 2021

Thanks! 🚀

@miccoli miccoli deleted the bugfix/version branch March 9, 2021 20:49
@miccoli
Copy link
Author

miccoli commented Mar 9, 2021

Thanks! 🚀

Thank you for providing this package.

khaeru added a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'sdmx.__version__' is not set properly
2 participants