Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error messages in layout.cc that print a 4-char tag #30

Merged
merged 1 commit into from
Jul 8, 2014
Merged

fix error messages in layout.cc that print a 4-char tag #30

merged 1 commit into from
Jul 8, 2014

Conversation

jfkthame
Copy link
Collaborator

@jfkthame jfkthame commented Jul 8, 2014

There are a bunch of messages in layout.cc that incorrectly try to print a tag by using %4s and passing (char*)&tag as the argument. To ensure no more than 4 chars are printed, they need to use %4.4s as the format.

(In addition, the messages incorrectly refer to the tag as "table", but in these cases it's not the table name, it's a subsidiary tag - script, language or feature.)

@khaledhosny
Copy link
Owner

Do you happen to know any fonts that trigger (some of) those errors?

@jfkthame
Copy link
Collaborator Author

jfkthame commented Jul 8, 2014

If you load http://spectrum.ieee.org/static/interactive-the-top-programming-languages with Firefox, with the developer console open, you'll see some of those error messages being reported in the log.

@khaledhosny khaledhosny merged commit e0ddbcd into khaledhosny:master Jul 8, 2014
@khaledhosny
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants