Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bogus metrics checks #37

Merged
merged 2 commits into from Oct 8, 2014
Merged

Bogus metrics checks #37

merged 2 commits into from Oct 8, 2014

Conversation

khaledhosny
Copy link
Owner

Drop the bogus adv, sb, and lsb checks. Fixes #36.

@behdad
Copy link
Contributor

behdad commented Oct 8, 2014

Going to merge this?

@khaledhosny
Copy link
Owner Author

I was hoping that you guys would have a look before I merge it.

@behdad
Copy link
Contributor

behdad commented Oct 8, 2014

I didn't notice that. Looks good to me. And I confirmed that it fixes the sb issue. Jonathan should comment on the warning / errors issue. But I think it's safe to merge. Thanks!

@khaledhosny
[ots] Distinguish between errors and warning
f468d7e 
Add a level parameter to the message callback that allows the clients to
handle errors and warning differently.

Related to #36
@khaledhosny
[ots] Disable bogus changes to metrics tables
c24a839 
Together with the warning messages.

Closes #36
@khaledhosny khaledhosny merged commit c24a839 into master Oct 8, 2014
@behdad
Copy link
Contributor

behdad commented Oct 9, 2014

Right.

This was referenced Oct 10, 2014
Closed
Closed
Closed
Closed
Closed
@khaledhosny khaledhosny deleted the issue-36 branch January 14, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bogus lsb check
3 participants
@khaledhosny @behdad @jfkthame