Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep.limits triggers error in plotEmbedding #139

Closed
teng-gao opened this issue Oct 25, 2022 · 3 comments
Closed

keep.limits triggers error in plotEmbedding #139

teng-gao opened this issue Oct 25, 2022 · 3 comments

Comments

@teng-gao
Copy link

In pagoda$plotEmbedding, keep.limits = T is supposedly able to help maintain axis limits while plot.na = F, but it triggers an error:

Error in embedding[, 1]: incorrect number of dimensions
@evanbiederstedt
Copy link
Collaborator

Yeah, this is a bug I can reproduce.

I'll fix and update shortly.

@evanbiederstedt evanbiederstedt assigned teng-gao and unassigned teng-gao Jun 13, 2023
@evanbiederstedt
Copy link
Collaborator

It's been almost a year. I realistically won't get to this bug any time soon.

It shouldn't be that complicated to fix.

Maybe it's something fun for @rrydbirk or others in his lab/group to fix. @teng-gao might have fun tackling this as well.

I'll put a help wanted ticket here.

@rrydbirk
Copy link
Contributor

Fixed in f65d0d6, I'll create a PR.

@rrydbirk rrydbirk mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evanbiederstedt @teng-gao @rrydbirk