Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add the ability to block users based on words/emojis in their username or display name #275

Merged
merged 6 commits into from
May 10, 2024

Conversation

MaxIsJoe
Copy link
Contributor

@MaxIsJoe MaxIsJoe commented May 3, 2024

closes #114

Allows blue blocker users to specifically block Twitter users with their own list of words/emojis.

This is intended to block users with inflammatory or offensive names, but can also be used to block users who you might not vibe with, simply by defining a few keywords or emojis that can be seen on usernames of people you don't want to see on your timeline or replies.

For example, if you don't want to see users with the glitched 🏳️‍🌈” ⃠, emojis, or if you don't want to see🔞due to it being associated with NSFW accounts which is something you don't want to interact with. Just add it to the list in the extension's settings.

image

Notes:

  • I was unable to test on firefox due to it not being able to load the manifest file for some reason.
  • the safelist buttons disappeared and I have no idea how to make them come back.

Changelog

  • [FEAT] Added the ability to block users based on disallowed words/emojis in usernames.

Deployment Checklist

  1. merge all pull requests to llb
  2. ensure src/manifest.ts and package.json have the correct version number
  3. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  4. merge llb to main
  5. upload zips from 3 to chrome webstore and firefox addons

Should let approval notes, license and release notes paramaters to be submitted
[chore/fix] bump firefox-addon version
@rougetimelord
Copy link
Collaborator

Going to change the base to the 0.4.2 LLB

@rougetimelord rougetimelord changed the base branch from main to 0.4.2 May 3, 2024 04:41
Copy link
Collaborator

@rougetimelord rougetimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you so much for getting on this! Great to see new contributors!

A couple of requested changes and suggestions for ya. Otherwise looks good to me.

src/popup/index.ts Outdated Show resolved Hide resolved
src/popup/index.ts Outdated Show resolved Hide resolved
src/popup/index.ts Outdated Show resolved Hide resolved
src/shared.ts Outdated Show resolved Hide resolved
src/popup/index.ts Outdated Show resolved Hide resolved
src/popup/index.ts Outdated Show resolved Hide resolved
src/popup/index.ts Outdated Show resolved Hide resolved
src/popup/index.html Outdated Show resolved Hide resolved
src/shared.ts Outdated Show resolved Hide resolved
@rougetimelord rougetimelord added this to the 0.4.2 milestone May 3, 2024
@rougetimelord rougetimelord added the enhancement New feature or request label May 3, 2024
@rougetimelord rougetimelord changed the title Add the ability to block users based on their disallowed words/emojis in usernames [Feat] Add the ability to block users based on words/emojis in their username or display name May 3, 2024
explain 'i'

Reapply "case insensitive"

This reverts commit ae0aa51.

Revert "case insensitive"

This reverts commit 2272caa.

case insensitive

Update index.ts

Update index.html

Update shared.ts

Stylizing changes, refactor element name, add status element

[Fix[ Unclosed textarea tag that caused safelist and integrations buttons to not render

Add a warning to the option explanation

Change to a better console log string

Use input number rules for textarea

Should make the textarea look more cohesive with the rest of the UI

[Fix] Typo

Refactor disallowed words update func, remove uneeded error logging, strip whitespace before storing

Update shared.ts

remove unused function
MaxIsJoe and others added 3 commits May 9, 2024 03:11
The array.join method does not add the separator to the end of the last array entry, but we need the lookahead on each entry to make sure we don't match on fragments inside of a word
@rougetimelord
Copy link
Collaborator

Going to give it a bit to see if anyone else wants to give reviews

@rougetimelord rougetimelord merged commit f76fd14 into kheina-com:0.4.2 May 10, 2024
@rougetimelord rougetimelord mentioned this pull request May 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: block accounts with display names containing characters from a user-defined list
2 participants