-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add the ability to block users based on words/emojis in their username or display name #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should let approval notes, license and release notes paramaters to be submitted
[chore/fix] bump firefox-addon version
Going to change the base to the 0.4.2 LLB |
rougetimelord
requested changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you so much for getting on this! Great to see new contributors!
A couple of requested changes and suggestions for ya. Otherwise looks good to me.
explain 'i' Reapply "case insensitive" This reverts commit ae0aa51. Revert "case insensitive" This reverts commit 2272caa. case insensitive Update index.ts Update index.html Update shared.ts Stylizing changes, refactor element name, add status element [Fix[ Unclosed textarea tag that caused safelist and integrations buttons to not render Add a warning to the option explanation Change to a better console log string Use input number rules for textarea Should make the textarea look more cohesive with the rest of the UI [Fix] Typo Refactor disallowed words update func, remove uneeded error logging, strip whitespace before storing Update shared.ts remove unused function
The array.join method does not add the separator to the end of the last array entry, but we need the lookahead on each entry to make sure we don't match on fragments inside of a word
rougetimelord
approved these changes
May 9, 2024
Going to give it a bit to see if anyone else wants to give reviews |
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #114
Allows blue blocker users to specifically block Twitter users with their own list of words/emojis.
This is intended to block users with inflammatory or offensive names, but can also be used to block users who you might not vibe with, simply by defining a few keywords or emojis that can be seen on usernames of people you don't want to see on your timeline or replies.
For example, if you don't want to see users with the glitched 🏳️🌈” ⃠, emojis, or if you don't want to see🔞due to it being associated with NSFW accounts which is something you don't want to interact with. Just add it to the list in the extension's settings.
Notes:
Changelog
Deployment Checklist
src/manifest.ts
andpackage.json
have the correct version numbermake chrome
,make firefox
)npm run build
3
to chrome webstore and firefox addons