Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] adds the option to skip blue checkmark users #278

Merged
merged 2 commits into from
May 16, 2024

Conversation

MaxIsJoe
Copy link
Contributor

closes #166

Adds the ability to skip over blue checkmark users because some users might want to only use this extension to block ads or offensive users, but not block every blue checkmark user out there.

Changelog

Summary
	1. document grouping follow 'SemVer2.0' protocol
	2. use 'PATCH' as a minimum granularity
	3. use concise descriptions
	4. type: feat \ fix \ update \ perf \ remove \ docs \ chore
	5. version timestamp follow the yyyy.MM.dd format

Deployment Checklist

  1. merge all pull requests to llb
  2. ensure src/manifest.ts and package.json have the correct version number
  3. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  4. merge llb to main
  5. upload zips from 3 to chrome webstore and firefox addons

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented May 10, 2024

out of scope of this PR, but once 0.4.2 is out; I'm considering cleaning up shared.ts as some functions are a bit too monolithic. BlockBlueVerified() alone is 230+ lines long, and that's without including the changes in #275

@cooljeanius
Copy link
Collaborator

eh... idk, I personally think it would be better to keep the extension focused on just what's in its name, but I guess that's not really my decision to make; I'll defer to @kheina on this...

@rougetimelord
Copy link
Collaborator

rougetimelord commented May 10, 2024 via email

@rougetimelord rougetimelord changed the base branch from main to 0.4.2 May 10, 2024 18:01
@rougetimelord rougetimelord added this to the 0.4.2 milestone May 10, 2024
Copy link
Collaborator

@rougetimelord rougetimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make more sense to name the setting key "block" to better align with the mute setting? Mostly a dev experience thing though

@rougetimelord
Copy link
Collaborator

out of scope of this PR, but once 0.4.2 is out; I'm considering cleaning up shared.ts as some functions are a bit too monolithic. BlockBlueVerified() alone is 230+ lines long, and that's without including the changes in #275

PLEASE!! Ideally we wouldn't even need shared.ts and would move all of the logic either into background.ts or content.ts

@rougetimelord
Copy link
Collaborator

Ninja'd on that merge lmfao

@rougetimelord
Copy link
Collaborator

Review now or forever hold your peace! (I wanna get 0.4.2 out the door 😭 )

Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine

@rougetimelord rougetimelord merged commit 6fb6616 into kheina-com:0.4.2 May 16, 2024
@rougetimelord rougetimelord mentioned this pull request May 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable blocking blue users
3 participants