-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] adds the option to skip blue checkmark users #278
[feat] adds the option to skip blue checkmark users #278
Conversation
out of scope of this PR, but once 0.4.2 is out; I'm considering cleaning up |
eh... idk, I personally think it would be better to keep the extension focused on just what's in its name, but I guess that's not really my decision to make; I'll defer to @kheina on this... |
eh... idk, I personally think it would be better to keep the extension focused on just what's in its name, but I guess that's not really my decision to make; I'll defer to @kheina on this...
I don't think it's a super out of place addition, we're already on the path
of letting other extensions implement their own logic for who to block and
letting users decide not to block people.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make more sense to name the setting key "block" to better align with the mute setting? Mostly a dev experience thing though
PLEASE!! Ideally we wouldn't even need shared.ts and would move all of the logic either into background.ts or content.ts |
Ninja'd on that merge lmfao |
Review now or forever hold your peace! (I wanna get 0.4.2 out the door 😭 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fine
closes #166
Adds the ability to skip over blue checkmark users because some users might want to only use this extension to block ads or offensive users, but not block every blue checkmark user out there.
Changelog
Deployment Checklist
src/manifest.ts
andpackage.json
have the correct version numbermake chrome
,make firefox
)npm run build
3
to chrome webstore and firefox addons