New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

left_joins_values should not be nil #9

Merged

khiav223577 merged 3 commits into master from feature/left_joins_values_should_not_be_nil

Apr 11, 2019

Owner

khiav223577 commented Apr 11, 2019

should be empty array if there is no left_joins values
Just like what joins_values behaves.
And left_joins_values is expected to be array in Rails source code.
https://github.com/rails/rails/blob/v5.2.3/activerecord/lib/active_record/relation.rb#L542-L544

khiav reoy added 3 commits

April 11, 2019 16:39


          test left_outer_joins_values

c143069


          left_outer_joins_values should not be nil

86325e4


          Merge branch 'master' into feature/left_joins_values_should_not_be_nil

463f93d

khiav223577 merged commit 581c119 into master

khiav223577 deleted the feature/left_joins_values_should_not_be_nil branch

April 11, 2019 09:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet