fix(hid): Eliminate data race in USB pathway causing dropped keys

Closes zmkfirmware#2253
khoek · Apr 7, 2024 · a7a2079 · a7a2079
1 parent 7d5aa0c
commit a7a2079
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/src/usb_hid.c b/app/src/usb_hid.c
@@ -23,6 +23,7 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
 static const struct device *hid_dev;
 
 static K_SEM_DEFINE(hid_sem, 1, 1);
+static uint8_t hid_ep_write_buf[sizeof(struct zmk_hid_keyboard_report)];
 
 static void in_ready_cb(const struct device *dev) { k_sem_give(&hid_sem); }
 
@@ -137,7 +138,8 @@ static int zmk_usb_hid_send_report(const uint8_t *report, size_t len) {
         return -ENODEV;
     default:
         k_sem_take(&hid_sem, K_MSEC(30));
-        int err = hid_int_ep_write(hid_dev, report, len, NULL);
+        memcpy(hid_ep_write_buf, report, len);
+        int err = hid_int_ep_write(hid_dev, hid_ep_write_buf, len, NULL);
 
         if (err) {
             k_sem_give(&hid_sem);