Use Java 11 - required for CloudStack 4.14 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khos2ow
reviewed
Mar 31, 2020
There was a problem hiding this comment.
Thank @olivierlemasle. The problem with this change is that it breaks backward compatibility and folks out there might still be on older version of CloudStack (considering that JDK 11 is enabled on 4.14+), so instead of modifying this file I'd suggest renaming it to centos7/Dockerfile.jdk8 and create a new file with your changes as centos7/Dockerfile.jdk11.
Also I just updated the CI config, if you can rebase and adjust Makefile and README that'd be awesome otherwise I can proceed with your PR and update them later.
|
And for that matter I'm thinking of the following images:
What do you think? |
|
Yes, sounds good! |
|
Rebased and adapted to propose both JDK 8 and JDK 11. |
khos2ow
approved these changes
Apr 1, 2020
|
Thank you @olivierlemasle 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JDK 11, as it is required by CloudStack 4.14 (cf apache/cloudstack#3601)