Wrong EGL native types used for QNX

[jmcdonnell-blackberry]

On QNX, __unix__ is also defined. Since the __unix__ block appears before the __QNX__ block, the Unix native types are chosen rather than the QNX native types. The __QNX__ block needs to precede the __unix__ block.

The __QNX__ block also needs to precede the WL_EGL_PLATFORM block. The existence of WL_EGL_PLATFORM doesn't necessarily indicate that Wayland is the native window platform. It only indicates that Wayland is a supported platform. For QNX, QNX Screen is currently the native window platform but Wayland may also be a window platform (accessed via eglGetPlatformDisplay, et al).

Really, it would be better if the native window platform was explicitly defined rather than being guessed. But that's probably something that can't be changed at this point.

[stonesthrow]

Agreed, unix should be last in the if-else sequence. Sorry we missed this.

It can be conflated, eglPlatform.h should be only indicating the default. That reordering seems OK.

I think it was supposed that the compiler would know the platform and and the macro set. But with multiple support there maybe many combinations of which goes first.

Do you want to propose a change to eglPlatform.h? The MR should be limited to just this change.

[jmcdonnell-blackberry]

Yes, I can propose a change.

[stonesthrow]

The "__unix__" clause seems like its a catch all for any undefined window system on a linux/unix platform. Jon may remember some history on this.

[oddhack]

I have a vague recollection of initially using some comparable set of ifdefs from Mesa headers. That was a long time ago.

[stonesthrow]

I think we'll need a couple of reviewers, so to check that we haven't inadvertently broke some platform. Especially around QNX, Wayland, Unix. where the change will touch.

[stonesthrow]

#192 is merged.
Closing issue