buffer overflow when there's a string literal at end of input, but without terminating null char #29

dneto0 · 2015-11-25T22:24:54Z

Also, there's an assert failure if the last instruction has a word count that extends beyond the input.

I have fixes for both queued up, buliding on #28

Add unit tests for all diagnostics issued by spvBinaryParse. Handle image format operands. Detect exhaustion of input when parsing an operand, to avoid buffer overruns on some invalid input cases. Fix the description strings for some operand types. Make the diagnostic messages for those operand types consistent between the assembler and binary parser. Fixes KhronosGroup#29

Add unit tests for all diagnostics issued by spvBinaryParse. Handle image format operands. Document that the callback function pointers can be null, in which case they are ignored. Detect exhaustion of input when parsing an operand, to avoid buffer overruns on some invalid input cases. Fix the description strings for some operand types. Make the diagnostic messages for those operand types consistent between the assembler and binary parser. Fixes KhronosGroup#29

Add unit tests for all diagnostics issued by spvBinaryParse. Handle image format operands in the binary parser and the disassembler. Document that the callback function pointers can be null, in which case they are ignored. Detect exhaustion of input when parsing an operand, to avoid buffer overruns on some invalid input cases. Fix the description strings for some operand types. Make the diagnostic messages for those operand types consistent between the assembler and binary parser. Fixes KhronosGroup#29

Add unit tests for all diagnostics issued by spvBinaryParse. Handle image format operands in the binary parser and the disassembler. Document that the callback function pointers can be null, in which case they are ignored. Detect exhaustion of input when parsing an operand, to avoid buffer overruns on some invalid input cases. Fix the description strings for some operand types. Make the diagnostic messages for those operand types consistent between the assembler and binary parser. Fixes #29

…sion Update SPIR-V core grammar revision number

dneto0 self-assigned this Nov 25, 2015

dneto0 closed this as completed in d9ad050 Nov 30, 2015

dgkoch pushed a commit to dgkoch/SPIRV-Tools that referenced this issue Nov 21, 2018

Merge pull request KhronosGroup#29 from antiagainst/core-grammar-revi…

b6dca23

…sion Update SPIR-V core grammar revision number

dneto0 mentioned this issue Jun 24, 2022

spirv-val: Validate zero product workgroup size #4828

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buffer overflow when there's a string literal at end of input, but without terminating null char #29

buffer overflow when there's a string literal at end of input, but without terminating null char #29

dneto0 commented Nov 25, 2015

buffer overflow when there's a string literal at end of input, but without terminating null char #29

buffer overflow when there's a string literal at end of input, but without terminating null char #29

Comments

dneto0 commented Nov 25, 2015