Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Timestamp to City and Numeric Code to Country. Fixed eloquent modeling on all models. Added two extra static Timezone functions to City #51

Merged
merged 5 commits into from
Dec 21, 2021

Conversation

seche
Copy link

@seche seche commented Jul 27, 2021

Bug Fix for Eloquent Models: added code to ignore that created_at and updated_at do not exist on the model.

Added to City Model a function timezoneAbbrev($iana_timezone) to retreive a timezone Abbreviation
Added to City Model a function timezoneOffset($iana_timezone) to retreive the timezone offset.

Mathieu Leblond added 2 commits July 27, 2021 15:58
… created_at and updated_at do not exhist.

Added to City Model a function timezoneAbbrev($iana_timezone) to retreive a timezone Abbreviation
Added to City Model a function timezoneOffset($iana_timezone) to retreive the timezone offset.
Added Database Migration for the Numeric Code on world_countries
@seche
Copy link
Author

seche commented Jul 27, 2021

Also working on seeding more data, just not ready to add it to the PR just yet.

@seche seche changed the title Added public $timestamps = false; to all Models to tell Eloquent that… Added Timestamp to City and Numeric Code to Country. Fixed eloquent modeling on all models. Added two extra static Timezone functions to City Jul 27, 2021
…can, Ecuador, Panama, Poland, Saudi Arabia, Sweden,Brazil, Cuba, India, Indonesia, Mexico, Netherlands, Nepal, Sudan, South Sudan.

Added a bunch of Cities.
Added a bunch of locales in French and English were it was missing for Cities, Divisions, Countries and Continents.
@seche
Copy link
Author

seche commented Jul 29, 2021

@khsing here you go. 3 different commits with my changes.

I also created myself a front end for data manipulation to use as a tool for Laravel Nova Admin Panel: https://packagist.org/packages/seche/nova-laravel-world

- updated city lists with cities with 5000+ population from Geonames Dump.

Source: https://download.geonames.org/export/dump/
@seche
Copy link
Author

seche commented Oct 12, 2021

Updated Cities Table with cities of 5000+ population from https://download.geonames.org/export/dump/.

Copy link

@umutphp umutphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate PR to solve multiple problems :).

Many thanks @seche . I hope It will be accepted by @khsing

@seche
Copy link
Author

seche commented Nov 12, 2021

Seems some cities are missing, I will update the data again in the coming days if life permits. Thanks :)

- Cleaned duplicates and added ALL cities from Geonames

Note: I had to split the seeding files for the cities to 30k records each due to file/memory limitations with PHP/Laravel.
@seche
Copy link
Author

seche commented Dec 15, 2021

@khsing I completed the data import/validation from Geonames. Roughly 200k cities

@khsing khsing merged commit f093d89 into khsing:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants