Skip to content

Commit

Permalink
usb: gadget: composite: Inform controller driver of self-powered
Browse files Browse the repository at this point in the history
commit 5e5caf4fa8d3039140b4548b6ab23dd17fce9b2c upstream.

Different configuration/condition may draw different power. Inform the
controller driver of the change so it can respond properly (e.g.
GET_STATUS request). This fixes an issue with setting MaxPower from
configfs. The composite driver doesn't check this value when setting
self-powered.

Cc: stable@vger.kernel.org
Fixes: 88af8bb ("usb: gadget: the start of the configfs interface")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Change-Id: If4018ee0b7ac0c34380e41b109a4e6a4af04417d
  • Loading branch information
Thinh Nguyen authored and Khusika Dhamar Gusti committed Jun 13, 2020
1 parent e3da9cc commit 0a4ab08
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/usb/gadget/composite.c
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,11 @@ static int set_config(struct usb_composite_dev *cdev,
else
power = min(power, 900U);
done:
if (power <= USB_SELF_POWER_VBUS_MAX_DRAW)
usb_gadget_set_selfpowered(gadget);
else
usb_gadget_clear_selfpowered(gadget);

usb_gadget_vbus_draw(gadget, power);
if (result >= 0 && cdev->delayed_status)
result = USB_GADGET_DELAYED_STATUS;
Expand Down Expand Up @@ -2482,6 +2487,7 @@ void composite_suspend(struct usb_gadget *gadget)
cdev->suspended = 1;
spin_unlock_irqrestore(&cdev->lock, flags);

usb_gadget_set_selfpowered(gadget);
usb_gadget_vbus_draw(gadget, 2);
}

Expand Down Expand Up @@ -2538,6 +2544,9 @@ void composite_resume(struct usb_gadget *gadget)
else
maxpower = min(maxpower, 900U);

if (maxpower > USB_SELF_POWER_VBUS_MAX_DRAW)
usb_gadget_clear_selfpowered(gadget);

usb_gadget_vbus_draw(gadget, maxpower);
}

Expand Down

0 comments on commit 0a4ab08

Please sign in to comment.