rebase #2
Open
rebase #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by renovateBot
SetICETimeouts and SetNAT1To1IPs are both incorrectly formatted
Today a remote `recvonly` transceiver can be satisfied by a `sendonly` or `sendrecv` transceiver. However a remote `sendonly` transceiver can only be satisfied by a `recvonly` transceiver. This PR updates the answer handling code to be more consistent.
Start new architecture section
Generated by renovateBot
Generated by renovateBot
Explain the implication of setting this
Allow users to explicitly configured the support EllipticCurves via public API.
Make updateConnectionState consistent with https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum
Generated by renovateBot
In step 5.3.1, since we do not have a sender we can only choose to signal that we need negotiation.
No functional change
Set cached values passed by SetBufferedAmountLowThreshold and OnBufferedAmountLow correctly when the underlying datachannel become open
Use bufferred channel (size 1) with select{} on write to avoid potential
deadlock
Generated by renovateBot
Generated by renovateBot
Update lint scripts and CI configs.
When there are more than one simucalst media lines in sdp, we need check mid when parse detail for simulcast track.
Everytime we receieve a new SSRC we probe it and try to determine the proper way to handle it. In most cases a Track explicitly declares a SSRC and a OnTrack is fired. In two cases we don't know the SSRC ahead of time * Undeclared SSRC in a single media section (#880) * Simulcast The Undeclared SSRC processing code would run before Simulcast. If a Simulcast Offer/Answer only contained one Media Section we would never fire the OnTrack. We would assume it was a failed Undeclared SSRC processing. This commit fixes the behavior.
Generated by renovateBot
ORTC API would return a nil SCTPTransport for DataChannels returned via Callback
In TestPeerConnection_Zero_PayloadType, WriteSample might be called after closePairNow, resulting in failure. This patch fixes the issue.
- Removes non-canon logic
Currently, AV1 or VP9 formats are matched regardless of the profile parameter. This was not noticeable until browsers started advertising multiple VP9 formats at the same time, each with a different profile ID, in order to allow the counterpart to send different streams on the basis of supported profiles. This causes two issues: first, the library includes in the SDP all formats passed by the browser, regardless of the fact that the profile ID is registered in the API or not. Then, the library is unable to choose the correct format for streaming, causing an intermittent failure. This patch fixes the matching algorithm and also covers the case in which the profile ID is missing, by using values dictated by specifications. Tests were refactored since previous ones covered the same lines multiple times.
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Don't block Close on spawned goroutines
Firefox would send updated header extension in renegotiation, e.g. publish a track without simucalst then renegotiate second track with simucalst, the two media secontions will have different rtp header extensions in offer. Need to match remote header extentions for each media sections to avoid second track publish failed.
Was accidentally copied, never needed
Ignore err from Fprintf
Not needed anymore
Generated by renovateBot
Generated by renovateBot
Added support for SRTP_NULL_HMAC_SHA1_80 protection profile (cipher). It is disabled by default. You need to use SettingEngine and set list of allowed SRTP protection profiles using its SetSRTPProtectionProfiles function called with dtls.SRTP_NULL_HMAC_SHA1_80 as a parameter. You need to do this for both pion peers. For non-pion ones you may need to enable it somewhere too, as NULL cipher is usually disabled for security reasons.
libwebrtc has started sending media probes on an unannounced SSRC(0). Currently Pion will ignore this as the SSRC hasn't been declared explicitly and no RID/MID RTP Headers. This adds a special case to accept SSRC 0 and Read the RTP packets. This allows the TWCC reports to properly be generated.
handleIncomingSSRC will call streamsForSSRC which opens rtp/rtcp streams that if unhandled can be leaked resources. Now we will proactively open them before calling handleIncomingSSRC and close then later. In the future it would be better to do this inside handleIncomingSSRC to protect other callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.