Skip to content

Commit

Permalink
fix(kiali-server): don't create unused ClusterRole (#261)
Browse files Browse the repository at this point in the history
Signed-off-by: Arthur Le Roux <aleroux@wiremind.io>
  • Loading branch information
capuche2412 committed May 16, 2024
1 parent cb4aebc commit ff22e32
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions kiali-server/templates/role-viewer.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if or (.Values.deployment.view_only_mode) (ne .Values.auth.strategy "anonymous") -}}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Expand Down Expand Up @@ -92,3 +93,4 @@ rules:
verbs:
- get
...
{{- end -}}
4 changes: 3 additions & 1 deletion kiali-server/templates/role.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not (or (.Values.deployment.view_only_mode) (ne .Values.auth.strategy "anonymous")) -}}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Expand Down Expand Up @@ -59,7 +60,7 @@ rules:
- security.istio.io
- extensions.istio.io
- telemetry.istio.io
- gateway.networking.k8s.io
- gateway.networking.k8s.io
resources: ["*"]
verbs:
- get
Expand Down Expand Up @@ -99,3 +100,4 @@ rules:
verbs:
- get
...
{{- end -}}

0 comments on commit ff22e32

Please sign in to comment.