Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out the ossmc image check - we will not smoke test it. #259

Merged
merged 1 commit into from
May 7, 2024
Merged

comment out the ossmc image check - we will not smoke test it. #259

merged 1 commit into from
May 7, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented May 6, 2024 •
edited

@jmazzitelli jmazzitelli self-assigned this May 6, 2024
@jmazzitelli jmazzitelli mentioned this pull request May 6, 2024
Closed
jshaughn
jshaughn approved these changes May 7, 2024
View reviewed changes
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, not even sure why we need the commented code but not a problem.

@jmazzitelli
Copy link
Contributor Author

not even sure why we need the commented code but not a problem

  1. In case we ever want to resurrect it, we just uncomment
  2. In case someone wanted to add that without knowing the history, there is the link to the issue explaining why it is commented out.

Doesn't hurt anything, as you say; I'm going to leave it as a breadcrumb for someone in the future.

@jmazzitelli jmazzitelli merged commit 1eb0794 into kiali:master May 7, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the do-not-smoke-test-ossmc branch May 7, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 24-7 | Kiali v1.86
Archived in project
Milestone
No milestone
2 participants
@jmazzitelli @jshaughn