Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out the ossmc image check - we will not smoke test it. #259

Merged
merged 1 commit into from
May 7, 2024
Merged

comment out the ossmc image check - we will not smoke test it. #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions hack/smoke-test-release-branch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ fi
# Determine the version we are going to smoke test
OPERATOR_VERSION="$(ls -1 docs/kiali-operator-*.tgz | sort | tail -n1 | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+')"
SERVER_VERSION="$(ls -1 docs/kiali-server-*.tgz | sort | tail -n1 | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+')"
OSSMC_VERSION="${SERVER_VERSION}"

if [ "${OPERATOR_VERSION}" != "${SERVER_VERSION}" ]; then
abort_now "The latest helm chart versions for operator [${OPERATOR_VERSION}] and server [${SERVER_VERSION}] do not match. Aborting the test."
Expand Down Expand Up @@ -242,11 +241,15 @@ fi

# SMOKE TESTING THAT THE OSSMC IMAGE IS ON QUAY.IO

EXPECTED_OSSMC_IMAGE="quay.io/kiali/ossmconsole:v${OSSMC_VERSION}"
infomsg "Checking that the OSSMC image is published on quay.io at: ${EXPECTED_OSSMC_IMAGE}"
if ! docker pull ${EXPECTED_OSSMC_IMAGE} &>/dev/null ; then
abort_now "The OSSMC image is not published on quay.io. This is missing: [${EXPECTED_OSSMC_IMAGE}]. The smoke test has FAILED!"
fi
# Do not check if OSSMC image is on quay. The OSSMC image will not be on quay when this smoke test script is run.
# See https://github.com/kiali/kiali/issues/6865#issuecomment-2096469036

#OSSMC_VERSION="${SERVER_VERSION}"
#EXPECTED_OSSMC_IMAGE="quay.io/kiali/ossmconsole:v${OSSMC_VERSION}"
#infomsg "Checking that the OSSMC image is published on quay.io at: ${EXPECTED_OSSMC_IMAGE}"
#if ! docker pull ${EXPECTED_OSSMC_IMAGE} &>/dev/null ; then
# abort_now "The OSSMC image is not published on quay.io. This is missing: [${EXPECTED_OSSMC_IMAGE}]. The smoke test has FAILED!"
#fi

# SMOKE TESTING IS COMPLETE

Expand Down
Loading